search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

fix: Restrict the node nodes for Pod scheduling #2948

Closed purelind closed 2 months ago

purelind commented 2 months ago

Restrict the node nodes for Pod scheduling

ti-chi-bot[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the main change seems to be the addition of a node selector to restrict the scheduling of pods to specific nodes. Specifically, it adds a new key ci-nvme-high-performance to the node selector with a value of true.

However, there seems to be a problem with the diff. The report container has been removed from the pod specification, which may affect the functionality of the overall pipeline. It's unclear whether this is intentional or not. Additionally, the description "user image with tini" doesn't provide much context on what has changed.

To fix the potential problem, we need to ensure that the removal of the report container was intentional and does not affect the pipeline's functionality. If it was unintentional, we can suggest adding the container back to the pod specification.

As for the unclear description, we need more context to fully understand the changes. We can ask the author of the pull request to provide more information or clarify the description.

Overall, the changes seem relatively minor, but it's important to ensure that the removal of the report container was intentional and that the pipeline continues to function as expected.

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[pipelines/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment