search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

fix(br): use failpoint tidb-server instead #2950

Closed purelind closed 2 months ago

purelind commented 2 months ago

Since https://github.com/pingcap/tidb/pull/52734, we need to use failpoint tidb-server for br integration test

ti-chi-bot[bot] commented 2 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request and the provided diff, the key change is that the make build_for_br_integration_test command has been replaced with (make failpoint-enable && make && make failpoint-disable) command. This change is made to use the failpoint tidb-server instead of the regular tidb-server.

There are no potential problems identified in the pull request. However, it is recommended to test the changes in a local environment before merging the pull request to ensure that the changes do not cause any issues.

As for fixing suggestions, it is recommended to add some information to the pull request description about how the changes were tested and provide some results or logs to support the changes. This would help the reviewer to have a better understanding of the changes and ensure that the changes meet the acceptance criteria.

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[pipelines/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment