PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 97 forks source link

chore(tiproxy): apply prow-jobs to all branches #2954

Closed djshow832 closed 1 month ago

djshow832 commented 1 month ago

Apply pre-submit and post-submit prow-jobs all to all branches of TiProxy.

ti-chi-bot[bot] commented 1 month ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, the key changes in this PR are applying pre-submit and post-submit prow-jobs to all branches of TiProxy.

There are no major problems with this PR, but there are some minor issues that could be addressed:

Suggested fixes:

ti-chi-bot[bot] commented 1 month ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to applying pre-submit and post-submit prow-jobs to all branches of TiProxy. The diff shows changes made to two YAML files that contain the jobs configuration.

The changes made to both files are adding a regex pattern to match all branches instead of just the "main" branch. This change appears to be fine and does not seem to cause any issues.

However, as a suggestion, it may be useful to add some comments to describe the reasoning behind this change, especially if it is part of a bigger effort or if it may affect other aspects of the project.

Overall, the changes seem to be straightforward and should not cause any problems.

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow-jobs/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/prow-jobs/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline: