Closed wuhuizuo closed 1 month ago
I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, it seems that the changes made in PingCAP-QE/ci#2958 are being reverted. The diff shows that the Dockerfile URLs are being changed from the new location to the old one.
Potential problems with this pull request could be:
Some suggestions to fix these problems could be:
/review default
@wuhuizuo:
I have already done a preliminary review for you, and I hope to help you do a better job.
It seems this pull request is reverting a previous change that broke the dev-builds due to a problem with the Docker build command. The change that is being reverted is a refactor of the Jenkins pipelines that changed the location of the Dockerfile URLs.
There are no potential problems with the code changes since the pull request is just reverting a previous change. However, there might be issues with the dev builds if the previous problem is not resolved.
My suggestion is to investigate the issue with the Docker build command and fix it before attempting to refactor the Jenkins pipelines. Once the issue is fixed, the previous refactor can be revisited and implemented again.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: wuhuizuo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Reverts PingCAP-QE/ci#2958
It broken the dev-builds since of the issue, we must solve it atomic: