ti-chi-bot[bot]
commented
1 month ago I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, the key change in this pull request is fixing the pip3 install issue in the CI pipeline for the PingCAP documentation project. Specifically, the fix involves adding --trusted-host flags to the pip3 install command to bypass any potential firewall issues.
One potential problem with this fix is that it is not clear what the underlying cause of the pip3 install issue is. If it is indeed caused by a company firewall, then adding the --trusted-host flags should be sufficient. However, if there are other underlying issues, then this fix may not be effective or may only be a temporary solution.
Another potential problem is that the use of sudo in the pip3 install command may cause permission issues, depending on the environment in which the pipeline is running.
To address these potential problems, it may be worth investigating further to identify the root cause of the pip3 install issue. Additionally, it may be worth considering alternative solutions that do not involve using sudo or bypassing the firewall.
One possible alternative solution is to use a Docker image that already has the necessary Python packages pre-installed, rather than relying on the pip3 install command in the pipeline. Another possible solution is to use a local Python virtual environment within the pipeline, which would not require sudo permissions and would not be affected by company firewalls.
Overall, while the fix in this pull request may be effective in the short term, it is important to consider the potential problems and explore alternative solutions to ensure a robust and sustainable CI pipeline for the PingCAP documentation project.
wuhuizuo
Maybe company firewall has forbidden the hosts.
Ref: https://jhooq.com/pip-install-connection-error/#1-root-cause-of-the-problem
Signed-off-by: wuhuizuo wuhuizuo@126.com