PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 100 forks source link

update utf go build image #2965

Closed aytrack closed 4 months ago

ti-chi-bot[bot] commented 4 months ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and the diff, it seems the change is updating the Docker image used for building Go code from hub.pingcap.net/chenpeng/golang:1.18 to hub.pingcap.net/jenkins/centos7_golang-1.21:latest.

Potential problems:

Fixing suggestions:

Overall, it's a simple change, but it's important to ensure that the new Docker image doesn't introduce any unexpected issues.

wuhuizuo commented 4 months ago

/lgtm /approve

ti-chi-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[jenkins/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/jenkins/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 4 months ago

[LGTM Timeline notifier]

Timeline: