PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

cdc: fix sync diff version #2973

Closed CharlesCheung96 closed 1 month ago

ti-chi-bot[bot] commented 1 month ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the diff provided, it seems that the pull request aims to update the sync_diff_inspector_url from sync_diff_inspector_hash-00998a9a_linux-amd64.tar.gz to sync_diff_inspector_hash-79f1fd1e_linux-amd64.tar.gz. This change is intended to fix the synchronization diff version in the ticdc_download_integration_test_binaries.sh script.

There do not appear to be any potential problems with this change, as it is a straightforward update of a URL reference. However, it would be helpful if the pull request had more detailed information about why this change is necessary.

As for fixing suggestions, there are none needed as the pull request appears to be a simple and correct modification.

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/PingCAP-QE/ci/blob/main/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline: