PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

fix(docs&docs-cn): update to image with pre install python3 packages #2978

Closed purelind closed 1 month ago

purelind commented 1 month ago

update to image with pre install python3 packages

ti-chi-bot[bot] commented 1 month ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change seems to be updating the Docker image with pre-installed Python3 packages.

The diff shows that the only change made is to update the version of the Docker image in two YAML files. However, there is commented-out code that suggests that pre-installing Python3 packages was initially a TODO item but was not implemented in this pull request. This should be addressed to ensure consistency between the pull request description and the actual changes made.

Additionally, it is unclear what the purpose of updating the Docker image version is. If this is related to security or performance improvements, it should be explicitly stated in the pull request description.

Suggestions:

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[pipelines/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment