search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

opt(pingcap/tidb-dashboard): speedup image building fo linux/arm64 target #2989

Closed wuhuizuo closed 2 weeks ago

wuhuizuo commented 2 weeks ago

Signed-off-by: wuhuizuo wuhuizuo@126.com

ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and the description of the Pull Request, it seems that the key change is to speed up the image building process for linux/arm64 target by using a pre-built Docker image from ghcr.io/pingcap-qe/cd/builders/tidb-dashboard.

Overall, the changes look good. By using a pre-built Docker image, the build process will be faster and more efficient. However, there are some suggestions for further improvement:

  1. The Dockerfile in the diff does not seem to reflect the changes mentioned in the Pull Request. It still uses the original centos:7 base image and installs Golang, Node.js, and Java, which are not needed if using a pre-built image. The original Dockerfile should be removed or updated to reflect the changes.
  2. It would be helpful to add some comments in the Jenkinsfile explaining the changes and the reasons behind them to make it easier for future maintainers to understand the code.
  3. It would be good to test the changes locally before merging the Pull Request to ensure that everything works as expected.

Overall, the changes look good, and once the Dockerfile and Jenkinsfile are updated, the Pull Request can be merged.

wuhuizuo commented 2 weeks ago

replay in: https://cd.pingcap.net/blue/organizations/jenkins/build-tidb-dashboard/detail/build-tidb-dashboard/162/pipeline/17

wuhuizuo commented 2 weeks ago

/approve

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[jenkins/pipelines/cd/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/jenkins/pipelines/cd/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment