search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

fix(ti-community-infra/prow): bump job images #2992

Closed wuhuizuo closed 2 weeks ago

wuhuizuo commented 2 weeks ago

to gcr.io/k8s-staging-test-infra/kubekins-e2e:v20240515-17c6d50e24-test-infra

Signed-off-by: wuhuizuo wuhuizuo@126.com

ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the pull request, it seems that the changes are related to updating the job images for the TI community infra Prow.

The changes made in the pull request are updating the image tag for the job containers in both prow/presubmits.yaml and prow/postsubmits.yaml files. The new tag is v20240515-17c6d50e24-test-infra instead of the old one v20230222-b5208facd4-test-infra and v20230926-f045ae1296-test-infra.

There are no potential problems identified with the changes made in the pull request. However, it is recommended to verify that the new images are available in the specified repository and that they do not cause any issues with the existing workflow.

One suggestion for improvement is to include a brief explanation in the pull request description about why the image tag needed to be updated. This way, other contributors can easily understand the reason behind the change.

Another suggestion is to add a comment in the pull request for the maintainers to verify that the new images are available and have been tested before merging the pull request.

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow-jobs/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/prow-jobs/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment