search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

fix(scripts/artifacts): not override other parts in output file #2994

Closed wuhuizuo closed 2 weeks ago

wuhuizuo commented 2 weeks ago

Signed-off-by: wuhuizuo wuhuizuo@126.com

ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the changes in this PR involve fixing a bug where output file parts were being overridden.

The diff shows that the change is made to two files, check-images-internal.sh and check-tiup.sh. In both files, there was a line that initialized the results file with : >results.yaml. This line was changed to use the yq command to add an empty object to the images and tiup fields respectively, so that the existing content of the output file is not overridden.

There are no potential problems that are immediately apparent in this PR.

As for fixing suggestions, it would be good to add a brief explanation in the pull request description of why the yq command is used instead of simply removing the : >results.yaml line. Additionally, it might be helpful to include a test plan for how this change will be tested to ensure that the fix works as intended.

wuhuizuo commented 2 weeks ago

/approve

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/PingCAP-QE/ci/blob/main/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment