search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

fix: fix tidb-tools presubmit config #2997

Closed purelind closed 2 weeks ago

purelind commented 2 weeks ago

fix tidb-tools presubmit config

ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the provided information, this pull request seems to be a simple fix to the presubmits.yaml file for the pingcap/tidb-tools repository. The change made is adding the decorate: false field to the pingcap/tidb-tools/pull_verify job. This job is run when a pull request is opened or updated in the pingcap/tidb-tools repository.

There aren't any obvious potential problems with this pull request. However, it's always a good practice to double-check that the change does not introduce any unwanted side effects. In this case, the change only affects the pingcap/tidb-tools/pull_verify job, so the impact should be minimal.

As for the suggested fix, since this change is relatively simple, it seems that the code is already in good shape. Therefore, I would just suggest double-checking that the change only affects the pingcap/tidb-tools/pull_verify job and ensuring that the code passes all necessary tests before merging the pull request.

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[prow-jobs/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/prow-jobs/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment