search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

fix: temp comment cross-compile platform darwin #2999

Closed purelind closed 2 weeks ago

purelind commented 2 weeks ago

temp comment cross-compile platform darwin. cross-compile on Linux amd64 for the platform GOOS=darwin GOARCH=amd64 will encountered error.

ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, it seems that the changes made are commenting out two lines of code that perform cross-compilation for the platform GOOS=darwin GOARCH=amd64. The reason for this change is that the cross-compilation on Linux amd64 for the platform GOOS=darwin GOARCH=amd64 will encounter an error.

The potential problem with this change is that it could lead to a situation where the application is not built for the darwin platform, which could cause issues during deployment.

One potential fix for this issue is to find a way to properly perform cross-compilation for the darwin platform without encountering errors. Alternatively, if cross-compilation is not possible, the application could be built natively on the darwin platform to ensure that it is properly optimized for that platform.

Additionally, it may be helpful to provide more context and details about the error that is encountered during cross-compilation to help other developers understand the issue and potential solutions.

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[pipelines/pingcap/tidb-tools/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/pingcap/tidb-tools/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment