Closed purelind closed 2 weeks ago
I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request adds integration tests to the pingcap/tidb-tools
pipeline. The changes include adding a new stage for Integration Test, downloading and extracting artifacts, and running integration tests. The integration tests include checking if the required binaries are present, testing MySQL connection, and running the integration tests.
Some potential problems that could arise from this pull request include:
make integration_test
command does not have any arguments to specify which tests to run, which could lead to running all tests instead of just the necessary ones.To fix these issues, I suggest the following:
make integration_test
command to specify which tests to run.[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here
add integration tests