PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

feat(pingcap/tidb-tools): enable new tidb-tools pipelines #3003

Closed purelind closed 2 weeks ago

purelind commented 2 weeks ago

enable new tidb-tools pipelines

ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that this PR enables new tidb-tools pipelines. However, the diff only shows changes related to disabling some Jenkins pipeline jobs and modifying a Prow job configuration.

The changes to disable the Jenkins pipeline jobs are concerning, as disabling jobs can potentially impact the CI/CD process and delay the detection of issues. It's important to understand why these jobs were disabled and whether it's necessary to disable them.

The changes to the Prow job configuration seem reasonable, as the always_run flag was set to true and the optional flag was set to false for the pull-verify context. However, it's unclear why the context was changed from wip-pull-verify to pull-verify. It's important to ensure that the context names are consistent and meaningful.

Fixing suggestions:

wuhuizuo commented 2 weeks ago

/lgtm

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[jenkins/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/jenkins/OWNERS)~~ [wuhuizuo] - ~~[pipelines/pingcap/tidb-tools/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/pipelines/pingcap/tidb-tools/OWNERS)~~ [wuhuizuo] - ~~[prow-jobs/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/prow-jobs/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline: