search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

fix(scripts/opt): update to new deno version #3004

Closed wuhuizuo closed 2 weeks ago

wuhuizuo commented 2 weeks ago

Signed-off-by: wuhuizuo wuhuizuo@126.com

ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the main change here is updating the Deno version in the script. Specifically, the exec function from the deno.land/x/exec module is being replaced with Deno.Command to make use of the new API introduced in Deno. Additionally, some console logs were added to provide more information about the progress of the script.

One potential problem I see is that the sumCloc function, which is defined in the code but not used anywhere, can be safely removed to avoid confusion. Another potential issue is that the diff shows the removal of some branches in the repos array, which might cause some side effects if those branches were being used elsewhere.

As for fixing suggestions, it might be helpful to add some more details to the pull request description to explain the reasoning behind the changes and provide some context for the reviewer. It might also be a good idea to test the script with different scenarios to make sure everything is working as expected with the new Deno version. Finally, it might be worth considering reverting the changes related to the repos array if they are no longer needed.

wuhuizuo commented 2 weeks ago

/approve

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/PingCAP-QE/ci/blob/main/OWNERS)~~ [wuhuizuo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment