PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

pd: make real cluster test run #3006

Closed HuSharp closed 2 weeks ago

ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and the diff, it seems that the changes are related to enabling the pull_integration_realcluster_test in the latest-presubmits.yaml file for the tikv/pd repository. Specifically, the changes are setting always_run to true and removing optional flag.

It is difficult to identify potential problems without any description or context about the changes made in this pull request. However, a potential problem could be that the pull_integration_realcluster_test is not stable yet and setting always_run to true and removing optional flag could lead to frequent failures or delays in the CI/CD pipeline.

As a fixing suggestion, the pull request author could provide more context and information about the stability of the pull_integration_realcluster_test and if there are any known issues. Additionally, they could consider keeping the optional flag until the test is stable and consistently passing.

HuSharp commented 2 weeks ago

test is: https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Fpd%2Fpull_integration_realcluster_test/activity/

ti-chi-bot[bot] commented 2 weeks ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/PingCAP-QE/ci/pull/3006#pullrequestreview-2124808270): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 weeks ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and the diff, it seems that the changes are related to the CI/CD pipeline for the Tikv project's PD component. Specifically, the changes are making the real cluster test run by setting always_run to true and optional to true.

There are no potential problems with the changes in the pull request, but there is a missing description which makes it difficult to determine what the changes are intended to do.

As a fixing suggestion, the pull request should include a detailed description of the changes made and why they are necessary. This will help future reviewers and contributors to better understand the purpose of the changes.

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow-jobs/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/prow-jobs/OWNERS)~~ [purelind] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline: