PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

fix: fix jobdsl error #3012

Closed purelind closed 1 week ago

purelind commented 1 week ago

User description

fix jobdsl error


PR Type

Bug fix


Description


Changes walkthrough ๐Ÿ“

Relevant files
Bug fix
14 files
pull_common_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_common_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_e2e_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_e2e_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_br_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_br_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_common_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_common_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_copr_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_copr_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_ddl_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_ddl_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_jdbc_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_jdbc_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_lightning_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_lightning_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_mysql_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_mysql_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_nodejs_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_nodejs_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_integration_python_orm_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_python_orm_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_mysql_client_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_mysql_client_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_sqllogic_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_sqllogic_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     
pull_tiflash_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_tiflash_test.groovy - Fixed incorrect closing quote in `scriptPath` string.
+1/-1     

๐Ÿ’ก PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

ti-chi-bot[bot] commented 1 week ago

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request fixes a typo in the scriptPath parameter in several pipeline job definitions. The change is straightforward and does not introduce any new code. Therefore, it is a low-risk change.

There are no potential problems with this change.

Suggestions:

ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[jobs/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/jobs/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codiumai-pr-agent-pro[bot] commented 1 week ago

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide ๐Ÿ”

โฑ๏ธ Estimated effort to review [1-5] 2
๐Ÿงช Relevant tests No
๐Ÿ”’ Security concerns No
โšก Key issues to review None
codiumai-pr-agent-pro[bot] commented 1 week ago

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions โœจ

CategorySuggestion                                                                                                                                    Score
Possible issue
Ensure the scriptPath is correctly formatted with double quotes ___ **Ensure that the scriptPath is correctly formatted with double quotes to avoid potential
syntax errors.** [jobs/pingcap/tidb/release-8.2/pull_common_test.groovy [19]](https://github.com/PingCAP-QE/ci/pull/3012/files#diff-bc9be55fca5219d01346f9186d6ff70865c79c83012090dbf9f7cc714ddd9a8aR19-R19) ```diff +scriptPath("pipelines/pingcap/tidb/release-8.2/pull_common_test.groovy") - ``` - [ ] **Apply this suggestion**
Suggestion importance[1-10]: 10 Why: The suggestion correctly identifies and fixes a syntax error in the `scriptPath` by replacing a single quote with double quotes, which is crucial to avoid script failures.
10