search

PingCAP-QE / ci

Continue intergration tests
Apache License 2.0
19 stars 96 forks source link

feat: daily internal build add release-8.1 #3013

Closed purelind closed 1 week ago

purelind commented 1 week ago

User description

daily internal build add release-8.1

PR Type

enhancement

Description

Changes walkthrough 📝

Relevant files
Enhancement
release_all_images_by_branch_for_internal.groovy
Add scheduled pipeline job for release-8.2 branch               
jenkins/jobs/cd/release_all_images_by_branch_for_internal.groovy - Added a new scheduled pipeline job for the `release-8.2` branch.
+1/-0     

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

ti-chi-bot[bot] commented 1 week ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request information, it seems that the changes add a new build job for the release-8.2 branch in the release_all_images_by_branch_for_internal.groovy file. Here are some potential problems and suggestions for fixing them:

  1. The pull request title and description are not very descriptive. It would be helpful to provide more information about the changes made in the pull request.
  2. The new job for release-8.2 is scheduled to run at 20 19 * * *, which overlaps with the job for release-8.1 that runs at 50 18 * * *. This could cause conflicts if both jobs try to build at the same time. To avoid this, the new job should be scheduled to run at a different time.
  3. It is not clear what the purpose of NEED_MULTIARCH is. If it is not necessary for the new job, it should be removed to simplify the code.

Suggestions for fixing these issues are:

  1. Update the pull request title and description to provide more information about the changes made.
  2. Change the schedule for the new job to run at a different time that does not conflict with other jobs.
  3. Remove NEED_MULTIARCH if it is not necessary for the new job.
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[jenkins/jobs/cd/OWNERS](https://github.com/PingCAP-QE/ci/blob/main/jenkins/jobs/cd/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codiumai-pr-agent-pro[bot] commented 1 week ago

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 1
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review None
codiumai-pr-agent-pro[bot] commented 1 week ago

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Possible issue
Adjust the cron schedule for the new job to avoid overlapping with existing jobs ___ **Ensure that the new cron job for release-8.2 does not overlap with existing jobs to avoid
potential conflicts or resource contention.** [jenkins/jobs/cd/release_all_images_by_branch_for_internal.groovy [34]](https://github.com/PingCAP-QE/ci/pull/3013/files#diff-0eb6ca11ab0a9f0ce99e186582f939937c7b85d329fb5914669531e43380e5e3R34-R34) ```diff -20 19 * * * % GIT_BRANCH=release-8.2;FORCE_REBUILD=false;NEED_MULTIARCH=true +10 19 * * * % GIT_BRANCH=release-8.2;FORCE_REBUILD=false;NEED_MULTIARCH=true ``` - [ ] **Apply this suggestion**
Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies potential scheduling conflicts in cron jobs, which is important for system stability and resource management. However, the exact timing change suggested (from 20 to 10 minutes past the hour) is arbitrary without specific system context, but the general idea of adjusting the time to prevent overlap is valid.
7