Closed qiancai closed 2 months ago
I have already done a preliminary review for you, and I hope to help you do a better job.
From the title and description, it seems that this PR is removing v5.1 and v7.5 PDFs as they are now archived. Looking at the diff, it appears that the changes are only in the docs-postsubmits.yaml
and docs-cn-postsubmits.yaml
files. The changes involve updating the regular expressions for the allowed release branches for PDF builds to exclude v5.1 and v7.5 releases.
Overall, the changes seem straightforward and appropriate. However, it might be worth checking if there are any other dependencies or components that use the v5.1 and v7.5 releases. If so, this PR might break the build for those components. Additionally, it would be helpful to confirm with the documentation team that these PDFs are no longer needed and can be safely removed.
As for fixing suggestions, the changes seem appropriate, so there's no need for any additional changes. However, it might be helpful to add a comment explaining why v5.1 and v7.5 releases were removed from the allowed release branches for PDF builds. This would help future contributors to understand the reasoning behind these changes.
Hi @qiancai. Thanks for your PR.
I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.
โฑ๏ธ Estimated effort to review: 1 ๐ตโชโชโชโช |
๐งช No relevant tests |
๐ No security concerns identified |
โก No key issues to review |
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.
Category | Suggestion | Score |
Possible issue |
Include
___
**Update the regex for | 9 |
/ok-to-test
PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here.
/lgtm /aporove
PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: wuhuizuo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-07-22 06:42:42.957821387 +0000 UTC m=+854584.948762857
: :ballot_box_with_check: agreed by wuhuizuo.
User description
v5.1 and v7.5 PDFs are archived and will no longer trigger new PDF builds.
PR Type
configuration changes
Description
release-5.1
branch from postsubmits configuration indocs-cn-postsubmits.yaml
anddocs-postsubmits.yaml
.release-7.6
branch from postsubmits configuration indocs-cn-postsubmits.yaml
anddocs-postsubmits.yaml
.Changes walkthrough ๐
docs-cn-postsubmits.yaml
Update postsubmits configuration for archived branches
prow-jobs/pingcap/docs/docs-cn-postsubmits.yaml
release-5.1
from postsubmitsrelease-7.6
from postsubmitsdocs-postsubmits.yaml
Update postsubmits configuration for archived branches
prow-jobs/pingcap/docs/docs-postsubmits.yaml
release-5.1
from postsubmitsrelease-7.6
from postsubmits