search

PingoLH / FCHarDNet

Fully Convolutional HarDNet for Segmentation in Pytorch
MIT License
195 stars 52 forks source link

Add test.py for inferencing #29

Closed gachiemchiep closed 4 years ago

PingoLH commented 4 years ago

Hello, thank you very much for your contribution. Just one thing, the line 118 in validate.py is for replacing the .png extension. After removing this line and the file name will become *.png.jpg which is a little confusing. Do you meet any issue for this line that makes you remove it?

gachiemchiep commented 4 years ago

Hello, thank you very much for your contribution. Just one thing, the line 118 in validate.py is for replacing the .png extension. After removing this line and the file name will become *.png.jpg which is a little confusing. Do you meet any issue for this line that makes you remove it?

Hello @PingoLH
Some of my files have ".jpeg" extensions. The fname_new = fname_new[:-4] will create a *..jpg. So i remove it. Maybe it would better use the os.path.splitext for a correct naming.

gachiemchiep commented 4 years ago

Hello @PingoLH I revert the change in validate.py

PingoLH commented 4 years ago

Thank you very much for your contribution and issue report. I will modify the extension replacement for the issue.