Oled lib fix for p8 i2c

PinguinoIDE / pinguino-libraries

Pinguino librairies, keywords and other useful files.

24 stars 27 forks source link

Oled lib fix for p8 i2c #26

Closed PaoloDooM closed 2 years ago

PaoloDooM commented 2 years ago

IMG_20220505_025000 Fix OLED lib for P18FX550 microcontrollers and sdd1306 display (i2c protocol) .

MefhigosetH commented 2 years ago

Dear @PaoloDooM , welcome to the Pingüino Community, and welcome to GitHub too ;-) Thanks for your contribution.

I don't have an OLED at this moment to test this PR, but if your have tested it and works, I'll merge it.

I will wait for your feedback. Best regards.

PaoloDooM commented 2 years ago

@MefhigosetH thanks for the welcome, I managed to test the changes on a pic18f2550 using a sdd1306 under i2c protocol, in this branch are two corrections, a syntax correction in OLED.h and a conditional addition in OLED.c that sets the correct clock for i2c protocol on pic18f2250 and pic18f4550.

https://user-images.githubusercontent.com/60434183/166970723-9e5af7df-06c5-4a7e-9a66-0c07709ab64b.mp4

MefhigosetH commented 2 years ago

Merged 🎉

PaoloDooM commented 2 years ago

Merged 🎉

Woohoo 🥳 thanks!!