Fix proposal - Githubissues

bugdebugger commented 9 years ago

Hi,

I had these fixes lying around for some time. Just recently I found the time to bring them in mergeable state. These are mostly fixes for open tickets but also for a few unfilled bugs and one little editor feature as last commit.

I know this pull request is a bit on the big side. And I understand if you don't want to merge it as a whole or all parts of it.

If you want I can also split the fixes up into separate pull requests where possible. I just wanted to put this up here so you can check it out and maybe provide a bit of feedback .

Also this was done on linux. I didn't have a chance to try building it on windows but judging from the available VS build files they are very outdated anyways. No idea if the mac build would work.

P.S.: If you are interested I also have a fairly aggressive cleanup branch based off the work done for this pull request.

There I removed as much stuff as possible which is

commented out code
unreachable code if 0 and similar
unused functions/variables
Unused parts of code e.g. multiplayer, lightning
Unused resources (images, sounds, ...)
Currently not working code (lightmap, ambient, ...)

In order to decruft the code base a bit

Grumbel commented 9 years ago

Merged this one, as for the cleanup branch, I might cherry-pick some changes from that, but a lot of the unused code removal goes to far.

Grumbel commented 9 years ago

Merged some of the stuff from the cleanup branch into develop.

BTW. What do you use to find the dead code?

Pingus / pingus

Fix proposal #147