Closed gin0115 closed 1 year ago
Merging #112 (21bed96) into develop (2c43e9a) will not change coverage. The diff coverage is
100.00%
.:exclamation: Current head 21bed96 differs from pull request most recent head f207dd3. Consider uploading reports for the commit f207dd3 to get more accurate results
@@ Coverage Diff @@
## develop #112 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 206 206
===========================================
Files 17 17
Lines 526 526
===========================================
Hits 526 526
Impacted Files | Coverage Δ | |
---|---|---|
src/Application/App.php | 100.00% <100.00%> (ø) |
|
src/Application/App_Validation.php | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Makes all protected properties/methods in App_Validator private and class as final. (Not possible to really overwrite) Makes all protected properties/methods in App private, as class is marked as final Adds a few getter methods to the mock DI, Config & Loader classes, this allows for testing that the parameters are passed as expected and you do have access the instances used by the app. Tests are also added for this too.