search

Pink2Dev / Pink2

Pinkcoin 2 Qt wallet and daemon
https://getstarted.with.pink/
MIT License
29 stars 22 forks source link

Gitian builds #8

Open aistrych opened 6 years ago

aistrych commented 6 years ago

Why Pinkcoin is not using gitian building process? Is there any reason for that? It would be nice to have it for auto downloader and updater feature I try to implement in alternative desktop UI. It would be more secure to have that I think. Of course it requires multiple builders/signers so if it's a problem we can of course put ordinary checksums in release description to parse them during download and compare with downloaded daemon binaries.

JRedinger commented 6 years ago

We're all volunteers here doing the best we can with what we have and what time we can donate to the project. Everything not pink specific was inherited from the code bases it was forked from. If you want something done, do it. That's the way it is for all of us.

jcvernaleo commented 6 years ago

I think the main reason that gitian isn't used is that pink was forked from a fork of bitcoin that predates the use of gitian. One piece that might be helpful for this is to start with porting the depends directory from bitcoin which I believe the gitian builds need (I think, I could be wrong there). I've started on the depends stuff here: https://github.com/jcvernaleo/Pink2/tree/jcv_depends The reason I want this is so I can cross-compile for arm, but I think it will help in other build stuff too.

My branch isn't done (haven't had much time to work on it, hopefully will get it done in a week or so but no promises).

There may be other bits of the build process that need modernizing before gitian would work but I haven't really looked so that might not be the case. Most of it should be fairly straightforward for anyone who wants to port the stuff from a recent bitcoin-core.

aistrych commented 6 years ago

@jcvernaleo Thanks. I will check your branch for sure. I've asked about gitian because Pinkcoin contrib directory contains Bitcoin devs pgp public keys as well as gitian descriptors so maybe it was already working back then. Don't know. That's why I asked in the first place. Will check and try to build it but definitely will check your branch also when it's ready.