search

PinkGoosik / visuality

Little visual improvements by adding a bunch of new particles.
https://modrinth.com/mod/visuality
MIT License
30 stars 15 forks source link

Better Combat incompatibility #34

Closed ZsoltMolnarrr closed 1 year ago

ZsoltMolnarrr commented 1 year ago

Hello!

I am developer of the Better Combat mod. We have the following incompatibility: https://github.com/ZsoltMolnarrr/BetterCombat/issues/156#issuecomment-1326857745

When Better Combat is installed, the entity.damage(DamageSource ...) function is only executed on the server side. But the server side cannot spawn particles.

So the only way to resolve this is to send a packet to the client with the information about particles. I understand this would require turning your mod not purely clientside.

If this would be implemented your mod could continue to function in clientside only and in server supported modes too.

ZsoltMolnarrr commented 1 year ago

I found the issue on my side. I was missing some client side logic.