2. airDrop ACL should be controled by another wallet. - Githubissues

PinkyNFT / pinky-contracs

Smart contracts related to v1 Pinky release

0 stars 0 forks source link

2. airDrop ACL should be controled by another wallet. #3

Closed zk1tty closed 9 months ago

zk1tty commented 9 months ago

airDrop will be triggered by a wallet set on the web application, correct? Then we should declare the dedicated wallet just having the control to call airDrop function, called AIRDROPPER.
- declare AIRDROPPER wallet address.
- add setAidDropper() function with onlyOwner ACL.
- change the ACL of airDropBulk from Owner to AIRDROPPER wallet.
- sample implementation using AccessControl library is here: https://docs.openzeppelin.com/contracts/5.x/access-control#role-based-access-control https://github.com/PinkyNFT/pinky-contracs/blob/796920a42c20d71522fa73af7f00d68abd65926a/contracts/PinkyToken.sol#L18-L21
```
function airDropBulk(
address[] memory _to,
uint256[] memory _amount
) external onlyOwner {
```

toufique-imam commented 9 months ago

@zkitty-norika check the new contract. AIRDROPPER_ROLE is added