put ACL for 2 mintNFT functions with MINTER_ROLE

PinkyNFT / pinky-contracs

Smart contracts related to v1 Pinky release

0 stars 0 forks source link

put ACL for 2 mintNFT functions with MINTER_ROLE #4

Closed zk1tty closed 9 months ago

zk1tty commented 9 months ago

Please force the msg.sender have to be the wallet having MINTER_ROLE (or MINTER if you don't use AccessControl library.)

declare MINTER_ROLE wallet address.
add the requirement that msg.sender have to be MINTER_ROLE
MINTER_ROLE should be managed on the environment valuables of Vercel.

https://github.com/PinkyNFT/pinky-contracs/blob/796920a42c20d71522fa73af7f00d68abd65926a/contracts/PinkyNFT.sol#L52-L90

toufique-imam commented 9 months ago

Minter role should be managed in vercel. How you will manage on chain condition using off chain data? And how the role giving process will occur

toufique-imam commented 9 months ago

@zkitty-norika check the new contract. Note that, in order to enable user minting function, you have to grant them that role now

zk1tty commented 9 months ago

Hi @toufique-imam, Maybe I got confused. Who calls mintNFTInCoin function? A user, correct? Then User can call directly. No need to input MINTER_ROLE. Sorry, that's my confusion.

toufique-imam commented 9 months ago

Okay I will revert it

toufique-imam commented 9 months ago

@zkitty-norika check the new contracts

zk1tty commented 9 months ago

This is done.