search

PinkyNFT / pinky-contracs

Smart contracts related to v1 Pinky release
0 stars 0 forks source link

Replace Admin_role with Ownable #5

Closed zk1tty closed 10 months ago

zk1tty commented 11 months ago

@toufique-imam To make sure that ownership transfer is available and will be recognized from Opensea and other marketplace user authorization, please go back to Ownable inheritance, instead of using ADMIN_ROLE. Because I'm not sure if we can use ADMIN_ROLE for user authorization at third-party market places like Opensea, Rarible, etc. I confirmed that Ownable works properly on all market places. https://github.com/PinkyNFT/pinky-contracs/blob/1fe1f7c5c951b89c216129027c3b6a90f62e86fc/contracts/PinkyNFT.sol#L11

toufique-imam commented 11 months ago

check new contracts @zkitty-norika

toufique-imam commented 10 months ago

@zkitty-norika did you check this?

zk1tty commented 10 months ago

@toufique-imam I'm reviewing right now.

zk1tty commented 10 months ago

Check #6. This issues is done.