search

PinkyNFT / pinky-contracs

Smart contracts related to v1 Pinky release
0 stars 0 forks source link

Review result of PoinkyNFT #6

Open zk1tty opened 9 months ago

zk1tty commented 9 months ago

  1. could you tell me which function call happend in case that we accept payment with PInkyToken on Polygon mainnet to issue NFT on other networks, like Aster zKatana mainnet. https://github.com/PinkyNFT/pinky-contracs/blob/289918f4eea7f974d49d90bd75c270a95df615a5/contracts/PinkyNFT.sol#L66-L90

  2. Please remove the commnet out to show the value of private valuables. https://github.com/PinkyNFT/pinky-contracs/blob/289918f4eea7f974d49d90bd75c270a95df615a5/contracts/PinkyNFT.sol#L17-L29

toufique-imam commented 9 months ago
  1. It's a impossible case where a token is in polygon and you are minting in other network. Note that it's just the variable name is pinkyToken. It can be any token that is deployed in the same network of PinkyNFT. @zkitty-norika
zk1tty commented 9 months ago

@toufique-imam

case where a token is in polygon and you are minting in other network.

  1. It's possible and potential future requirement on 2nd release. When we deploy the contract on other networks, we will change this mintNFTInToken () as follows.
    • ACL: only MINTER_ROLE, the secret key of MINTER_ROLE is managed on Env valuables on Vercel.
    • Tx flow: 2 txs occur.
  2. A user will send the Pinky Token on Polygon to Team wallet.
  3. Web BE confirm that Tx1 is finalized.
  4. MINTER_ROLE wallet on Web BE call mintNFTInToken ().
  5. A minted NFT token will be send to the wallet address of User.

Conclusion: @toufique-imam Current PinkyNFT contract is only for Polygon deployment. In case of other networks, please update the part of point 1 as I mentioned above.

toufique-imam commented 9 months ago

Okay I will update it

toufique-imam commented 9 months ago

@zkitty-norika please check the new contract

zk1tty commented 9 months ago

@toufique-imam I confirmed that you update mintNFTInToken. Looks good to me. Can you please mention the commit link with your comment for fast review from next time?

toufique-imam commented 9 months ago

Okay sure. like this, the commit b49ccd262ed012c6c8c093da54fd32b5e1dcff55

toufique-imam commented 7 months ago

if this is done, can you close it please