search

PintaProject / Pinta

Simple GTK# Paint Program
http://www.pinta-project.com/
MIT License
1.75k stars 267 forks source link

added Offset method to selection class #740

Closed zWolfrost closed 4 months ago

zWolfrost commented 4 months ago

This PR aims to close my issue (#661). It doesn't implement any GUI options, but hopefully it makes the job much easier for people that know how to add the buttons. I have tried my best to respect the project coding practices but i am kinda new to doing pull requests, so i would really like if this was tested first. To get into technical details, i have chosen the "jtMiter" JoinType as i think it's the most fitting between these options.

cameronwhite commented 4 months ago

The changes look good, thanks! I tried testing this out by just hacking it into the selection tool to always expand the selection, and it behaved as expected - I just noticed that the surface parameter is unused and could be removed

zWolfrost commented 4 months ago

Hi, just for carification, i added the unused surface parameter because the "Invert" method of the selection object also has it unused, so i figured i should add it as well. Anyway, i'm glad it works. Do you want me to remove the parameter?

cameronwhite commented 4 months ago

Thanks, yes please remove that parameter (and also may as well do this for the Invert() method too)

zWolfrost commented 4 months ago

There you go. I didnt remove it from invert method as well because that would require to edit every call of it and remove the paramether there as well, and my pc is not available at the moment.