search

PintaProject / Pinta

Simple GTK# Paint Program
http://www.pinta-project.com/
MIT License
1.74k stars 267 forks source link

Ensured that only instance properties (and no static properties) are used in `SimpleEffectDialog` #860

Closed Lehonti closed 3 weeks ago

Lehonti commented 3 weeks ago

CloudsData has a static property BlendOps, which SimpleEffectDialog tried to use and caused an error to occur because it doesn't have a getter, but again, this property is static and isn't supposed to be used. I added some more checks in the filtering part in order to make sure that only instance properties are used.

Still, I don't think this property belongs in CloudsData, so I moved it to CloudsEffect. If this is not desired, the last commit could be discarded.

cameronwhite commented 3 weeks ago

I think it's fine to move it into CloudsEffect

cameronwhite commented 3 weeks ago

Oh wait, I think moving the property out of CloudsData introduced an error, since the reflection for StaticList ("BlendOps") is looking for a field or property with that name, which no longer exists. Opening the clouds effect is throwing an exception from that now

cameronwhite commented 3 weeks ago

I can just revert the changes from that last commit