search

PintaProject / Pinta

Simple GTK# Paint Program
http://www.pinta-project.com/
MIT License
1.74k stars 267 forks source link

Added blend op choices property to `CloudsEffect`, and corrected behavior in `MemberReflector` #864

Closed Lehonti closed 3 weeks ago

Lehonti commented 3 weeks ago

In one of the previous pull requests, I filtered out static properties so that the SimpleEffectDialog didn't crash when CloudsEffect was chosen.

Now I've found that it still crashes because it can't find the member referenced in StaticListAttribute, so I added it as an instance property.

Also, the creation of MemberReflector throwed an exception whenever the property in question didn't have a setter. This is a temporary workaround.

Maybe static properties should be supported, at least in a limited fashion?

Lehonti commented 3 weeks ago

I see that this was fixed in a certain commit, but I'd still like to discuss the right architecture for it

cameronwhite commented 3 weeks ago

I think static properties should be filtered out when building the list of widgets, since any controls need to be instance properties. But it should be possible to query them for a StaticList attribute. Not sure if there are any other cases I'm missing, though.