Cannot drag curve in curves window of 2.1.2 (Flatpak)

PintaProject / Pinta

Simple GTK# Paint Program

http://www.pinta-project.com/

MIT License

1.74k stars 267 forks source link

Cannot drag curve in curves window of 2.1.2 (Flatpak) #871

Closed arxo closed 2 weeks ago

arxo commented 2 weeks ago

Description In the current Flatpak build of Pinta 2.1.2 altering the curve shape in the Curves adjustment window by dragging it with the mouse is broken.

To Reproduce

install Pinta from Flatpak
Open or create image
Select "Adjustments => Curves..."
Left-click onto the curve and move mouse to drag. => curve is not bent while dragging, remains fixed

Additional Info

Version Pinta 2.1.2 (Flatpak) on Linux Mint 21.3

cameronwhite commented 2 weeks ago

Right-click onto the curve and move mouse to drag I'm pretty sure it's always been left-click to add a control point and drag, and right-click to remove control points. Did this work differently before?

arxo commented 2 weeks ago

Sorry, I got the mouse buttons mixed up. It is left click to drag, corrected the bug description.

cameronwhite commented 2 weeks ago

Interesting, it works fine on my MacBook, but I was able to reproduce it on a Linux machine. However, after turning off Num Lock it did work - can you reproduce the same?

I think it might be related to this code which doesn't handle other modifiers being active, and I think Num Lock can cause that to happen sometimes https://github.com/PintaProject/Pinta/blob/release-2.1/Pinta.Effects/Dialogs/Effects.CurvesDialog.cs#L207

arxo commented 2 weeks ago

Bingo! :) For me it also works with Num Lock off, and fails as soon as I turn it on.