PintaProject / Pinta

Simple GTK# Paint Program
http://www.pinta-project.com/
MIT License
1.74k stars 267 forks source link

Refactored tools and services so that they don't reference `PintaCore` directly #893

Closed Lehonti closed 1 day ago

Lehonti commented 3 days ago

This is a follow-up to #870

A couple remarks, in order to help navigate these changes:

Lehonti commented 1 day ago

@cameronwhite I just suppressed the warnings :)

As for the changes that don't directly relate to what's being addressed in the PR: as you've seen, for quite some time now, along with the main changes in the PR in question I've been incorporating changes that are too small to have their own pull request (most commonly in the same files where I'm performing the main changes), in order to save space (because Git stores entire files). If I don't do it that way, how could it be done?

cameronwhite commented 1 day ago

Thanks! I don't know if there's a perfect answer, but it is more time-consuming to review large PRs when there are other formatting / style changes mixed in. I'd limit that to small PRs, or style-only PRs (but those shouldn't be a high priority to work on IMO)