Pioreactor / pioreactor

Hardware and software for accessible, extensible, and scalable bioreactors. Built on Raspberry Pi.
https://pioreactor.com
MIT License
100 stars 9 forks source link

Removing/unassigning/inactivating a leader from experiment with a running profile will end the profile #492

Open kellytr opened 7 months ago

CamDavidsonPilon commented 7 months ago

some notes:

  1. What if we make experiment profile as "long running?" Inactive would not kill it, but unassigned would.
  2. What if we make experiment profile not associated to an experiment? This would create conflicts if multiple profiles want to run for different experiments. It's also not clear how to kill it (and only it) from the command line: pio kill --name experiment_profile would kill all profiles, and pio kill --name experiment_profile --experiment <exp> would kill nothing.

Probably something along the lines of 1. makes more sense. However, what does kill this profile? pio kill --name experiment_profile --experiment <exp>, or over MQTT (UI). How do we handle unassignment killing it?

CamDavidsonPilon commented 7 months ago

Thinking more about this. How does one end an experiment profile? Either:

  1. It ends naturally
  2. The user stops it early from the /profiles page
  3. The experiment is ended (via the UI).