Pioreactor / pioreactor

Hardware and software for accessible, extensible, and scalable bioreactors. Built on Raspberry Pi.
https://pioreactor.com
MIT License
101 stars 9 forks source link

Ripping out *_controllers #515

Closed CamDavidsonPilon closed 4 months ago

CamDavidsonPilon commented 4 months ago

Controllers were introduced with the idea that users could quickly change automations. However, that goal has not really been realized:

I think there's are lots of pros to remove controllers and instead purely working with automations:

some potential APIs

This is probably the easiest to implement

pio run temperature_automation --automation-name thermostat --target-temperature 30

this requires dynamic click stuff, not great

pio run thermostat --target-temperature 30

Migration considerations

  1. New yaml job contrib files
  2. Experiment profiles need to be corrected. I think this is just a replacement s/controller/automation/g
  3. New docs
CamDavidsonPilon commented 4 months ago

Surgery successful