search

PiotrDabkowski / pyjsparser

Fast JavaScript parser for Python.
MIT License
249 stars 38 forks source link

Add Continuous Integration and increase test coverage #12

Open satwikkansal opened 7 years ago

satwikkansal commented 7 years ago

Hey, we've been using pyjsparser in our project coala-quickstart to parse JS files and extract information.

It would be great if we can have continuous integration for common platforms (ubuntu, windows, and osx) in the official repository of "pyjsparser".

Also, I tested the library for coverage and came to know it's around 30%. Maybe we can write more tests to improve the coverage of tests :sweat_smile:

Let me know what do you think of these ideas. If ideas seem worth executing, I'll also be able to help in the above tasks :smile:

PiotrDabkowski commented 7 years ago

There is no need to write new tests, we can use the same tests as esprima - you can find them here. It should not be hard to integrate them, the syntax tree returned by pyesprima is almost identical to the one returned by esptima.js. Note that pyesprima is based on the older version of esprima (2.2.0) so we would have to use the older version of their tests as well.

I am currently working on my thesis and ML projects so I will not be able to do that right now. I can assist in the process though if you want to give it a try :)

satwikkansal commented 7 years ago

Nice, I'm working on an information extraction project right now under coala for GSoC 17. I'll add the above mentioned tasks as stretch goals in my timeline and try them once I'm done with completing existing tasks that I've initially proposed for GSoC. Hope you're fine with this :)

PiotrDabkowski commented 7 years ago

Cool, good luck with the GSOC!