Use websocket-client for template-rendering

PiotrMachowski / Home-Assistant-Lovelace-HTML-Jinja2-Template-card

This card displays provided Jinja2 template as an HTML content of a card. It uses exactly the same engine as Home Assistant in Developer tools.

MIT License

68 stars 10 forks source link

Use websocket-client for template-rendering #2

Closed betaboon closed 4 years ago

betaboon commented 4 years ago

Motivation for this change:

I wanted to use this with non-admin users.
As the api-endpoint used for template-rendering is only available for admin-users this didn't work.
After talking to people on discord it turned out, that there is a template-render-call via websocket-client that works for non-admin users.

What I changed:

use subscribeRenderTemplate provided by card-tools to render the template

goldmann commented 4 years ago

I would love to have this solved, because I'm hitting the exactly same issue as @betaboon: cards are not rendered for non-admin users. The only downside I see is the addition of an external dependency: card-tools. I wonder if it could be dropped.

PiotrMachowski commented 4 years ago

@goldmann I want to avoid having external dependencies, so I haven't merged this PR. Migrating to WS API shouldn't be a big problem, I will take a look at it.

goldmann commented 4 years ago

@PiotrMachowski Fully agree on on the external dependencies. Thank you (for the card and looking at the issue)!

PiotrMachowski commented 4 years ago

I have migrated to WS without usage of card-tools