search

PiotrMachowski / Home-Assistant-custom-components-SmartThings-Soundbar

Samsung Smarthings API for controlling Soundbar
MIT License
92 stars 24 forks source link

Update api.py #8

Closed Zolli closed 3 years ago

Zolli commented 3 years ago

Removed unnecessary accessor when populating device sources Fixes #5

PiotrMachowski commented 3 years ago

This fix will probably break compatibility with older devices

Zolli commented 3 years ago

Okay, i check it, but i not see anythig else in the first place, because this component worked for me at least a month. and the error mentioned in the issue ticket is just started a week ago. Maybe the api response changed for specific devices?

PiotrMachowski commented 3 years ago

Yes, it seems like it has been changed for new devices - I use HW-Q80R and it works correctly.

Zolli commented 3 years ago

Woah, thats wierd :D I use a Q90R and the issue author is using a Q70R, its all from the same series.

PiotrMachowski commented 3 years ago

Ok, I have checked it and I have a pending update - it will probably break integration for me

PiotrMachowski commented 3 years ago

Can you run this script and send me results (2 txt files) here or at piotr.machowski.dev [at] gmail [dot] com?

PiotrMachowski commented 3 years ago

Issue should be fixed now