search

PiotrMachowski / Home-Assistant-custom-components-Xiaomi-Cloud-Map-Extractor

This custom integration provides a way to present a live view of a map for Xiaomi (Roborock/Viomi/Roidmi/Dreame) vacuums without a need for rooting.
MIT License
1.15k stars 122 forks source link

Basic functionality for ijai map acquisition and image rendering #527

Open Tarh-76 opened 5 months ago

PiotrMachowski commented 5 months ago

Hi @Tarh-76, thank you for your contribution! There's just one problem: at this moment the latest development version of the integration is on dev_extracted_libraries branch. On this branch map parsing has been extracted to appropriate libraries. Would you like to do the same for Ijai vacuums?

Tarh-76 commented 5 months ago

Hi @Tarh-76, thank you for your contribution! There's just one problem: at this moment the latest development version of the integration is on dev_extracted_libraries branch. On this branch map parsing has been extracted to appropriate libraries. Would you like to do the same for Ijai vacuums?

Hi Piotr, Thanks for the advice, sounds like a plan to me. Do I get it right that to follow it I should rebase my branch to dev_extracted_libraries branch? The thing is I'm kinda new to GitHub and may ask some not-so-smart questions.

PiotrMachowski commented 5 months ago

You can try to rebase it, but it might be quite hard (there are a lot of conflicts), so it might be easier to create a branch from dev_extracted_libraries and move your changes there manually. Also you would have to create a pip library that will contain map parser for Ijai vacuums (similarly to approach used here).