PiotrMachowski / Xiaomi-cloud-tokens-extractor

This tool/script retrieves tokens for all devices connected to Xiaomi cloud and encryption keys for BLE devices.
MIT License
3.17k stars 327 forks source link

Use curl instead of wget #75

Closed kasabov closed 1 year ago

kasabov commented 1 year ago

Readme page specifies the use of curl to download docker run script but then the script itself makes use of wget.

bash <(curl -L https://github.com/PiotrMachowski/Xiaomi-cloud-tokens-extractor/raw/master/run.sh)

It makes no sense to demand that users have both tools installed. I, for one, don't have wget installed.

PiotrMachowski commented 1 year ago

Good point, thank you

kasabov commented 1 year ago

I had some time free and decided to deal with this myself. Let me know if you have remarks.

PiotrMachowski commented 1 year ago

I have merged your changes (after minor adjustment), thank you

kasabov commented 1 year ago

Fantastic! Thanks, your help is appreciated. Merging this also resolves https://github.com/PiotrMachowski/Xiaomi-cloud-tokens-extractor/issues/71.