Fix - Rollup build - Githubissues

PiotrMachowski / lovelace-xiaomi-vacuum-map-card

This card provides a user-friendly way to fully control map-based vacuums in Home Assistant. Supported brands include Xiaomi (Roborock/Viomi/Dreame/Roidmi/Valetudo/Valetudo RE), Neato, Wyze, Roomba, Ecovacs (and probably more).

MIT License

1.48k stars 254 forks source link

Fix - Rollup build #689

Closed gentslava closed 9 months ago

gentslava commented 11 months ago

Rollup build config changes:

Removed rollup-plugin-serve in rollup.config.js -> Error https://github.com/PiotrMachowski/lovelace-xiaomi-vacuum-map-card/pull/687/checks#step:4:62 passed.
Added package-lock and npm ci for more stable and fast GitHub Actions build.

gentslava commented 11 months ago

Hello @PiotrMachowski I've added changes to production files. Please, review it. It should fix Rollut build and make GHA more stable and a little faster 😊 I haven't touch the rollup.config.dev.js and it still has same error on npm start cause of rollup-plugin-serve package.

gentslava commented 11 months ago

Hi @PiotrMachowski You can check it and re-run GHA. I've regenerated package-lock with the Node v14. In the prev commit I forgot to revert it after I've tried Node lts :D

gentslava commented 11 months ago

It works again 🎉 Now you can merge it. And I'll rebase branch with translation changes in PR #687 to make it buildable in GHA.

PiotrMachowski commented 9 months ago

Thanks, @gentslava!