Add Roborock Core as a platform

[Lash-L]

Integration repository

https://www.home-assistant.io/integrations/roborock/

Supported features

• [X] Zone cleaning (using 4 coordinates)
• [X] Room cleaning (using room id/number)
• [X] Going to point (using 2 coordinates)
• [X] Cleaning a point (using 2 coordinates)
• [ ] Others

Checklist

• [ ] I have sent info about entities to piotr.machowski.dev [at] gmail.com (Retrieving entities info; please provide your GitHub username in the email)

Vacuum entity/entities

n/a

Service calls

n/a

Other info

Creating this issue here to keep track of my work and ask questions. I plan to do the incorporation myself so I have left service calls and entities blank.

Roborock core holds the map in a image entity instead of a camera entity, so I got the calibration points from the map parser .calibration() and set up the following:

type: custom:xiaomi-vacuum-map-card
entity: vacuum.s7_roborock
map_source:
  image: image.s7_roborock_downstairs
calibration_source:
  calibration_points:
    - vacuum:
        x: 25500
        'y': 25500
      map:
        x: 240
        'y': 184
    - vacuum:
        x: 35500
        'y': 25500
      map:
        x: 440
        'y': 184
    - vacuum:
        x: 25500
        'y': 35500
      map:
        x: 240
        'y': -16

vacuum_platform: humbertogontijo/homeassistant-roborock

However, the image does not show up

Before I went any further I wanted to check with you that images are supported by the card.

[PiotrMachowski]

Before I went any further I wanted to check with you that images are supported by the card.

It should work, but you have to set it up using camera key:

map_source:
  camera: image.s7_roborock_downstairs

I suppose calibration points won't be added to the core, right?

[Lash-L]

Ah that did it - Guess I should have read the docs better.

I do plan to try to get calibration points added to core as an extra state attribute on the image entity, I think I'll be able to get that approved

[PiotrMachowski]

I think I'll be able to get that approved

In case of failure I think it won't be hard to inject appropriate code using a custom integration. Please include me in a potential PR regarding this feature

[Lash-L]

Please include me in a potential PR regarding this feature

Can do. Anything else that would be helpful for me to expose?

I have just started diving into your code, but one thing that is important with Roborock vacuums is that commands are map specific and room ids are not. So if I want to clean room id 12 on the downstairs map, if I click on that room to clean it, but I have the upstairs map selected as my current map, it will attempt to clean room id 12 upstairs.

Is there a means on the card to set the map you are interacting with as the current map?

[PiotrMachowski]

Anything else that would be helpful for me to expose?

roomssection would also be useful - it is used to automatically generate rooms config.

Is there a means on the card to set the map you are interacting with as the current map?

It is possible to add configs for multiple maps using additional_presets and make card automatically choose appropriate one using matching condition

More info e.g. here: https://github.com/PiotrMachowski/lovelace-xiaomi-vacuum-map-card/issues/248

[dkirby-ms]

Roborock core holds the map in a image entity instead of a camera entity, so I got the calibration points from the map parser .calibration() and set up the following:

Could you perhaps give more detail on how you are getting the map coordinates? I am using the new native Roborock integration. I have the image showing up but the calibration is off because I am not sure how to map the dock location to the image map.

[PiotrMachowski]

@dkirby-ms he modified the code of Roborock integration

[mistergyle]

is there any ongoing development on this issue? i would appreciate it!

[Lash-L]

is there any ongoing development on this issue? i would appreciate it!

I am unfortunately a bit blocked. Not much I can do at the moment and core devs have to make decisions.

[jason-curtis]

Is there a recommended workaround for generating calibration points at the moment? Docs point me towards https://github.com/PiotrMachowski/Home-Assistant-custom-components-Xiaomi-Cloud-Map-Extractor but I don't have a Xiaomi account as I've been using the Roborock app.

[PiotrMachowski]

You can use this integration instead: https://github.com/humbertogontijo/homeassistant-roborock

[jason-curtis]

I did just switch to the official integration because I was having issues with that one and was hoping this would be more stable. Is the humbertogontijo version preferred for the vacuum map card?

[PiotrMachowski]

@jason-curtis at this moment the official integration doesn't provide data that is necessary to use the map functionality in this card

[Maximus97]

I as well very much look forward to this card supporting the official Roborock integration

[Lash-L]

@PiotrMachowski since our original plan failed. Would a service call work?

I.e you could call vacuum: send command with a service that is like get_map_card_info and we get all of the initial info you need like calibration points, room dimensions, etc? Then we could still use the image entity to update what the map looks like?

[PiotrMachowski]

@Lash-L I think service call should be ok, but I also thought about implementing a dedicated WS API method. The downside of this approach is that it probably won't be possible for users to use it manually.

It would also be nice to make it possible for the card to be notified that something has changed in the calibration (I think this happens quite often during map building). Can it be solved by generating an event when it happens?

[carlos-48]

I got the calibration points from the map parser .calibration() and set up the following:

type: custom:xiaomi-vacuum-map-card
entity: vacuum.s7_roborock
map_source:
  image: image.s7_roborock_downstairs
calibration_source:
  calibration_points:
    - vacuum:
        x: 25500
        'y': 25500
      map:
        x: 240
        'y': 184
    - vacuum:
        x: 35500
        'y': 25500
      map:
        x: 440
        'y': 184
    - vacuum:
        x: 25500
        'y': 35500
      map:
        x: 240
        'y': -16

vacuum_platform: humbertogontijo/homeassistant-roborock

Hi! First of all, thanks for the integrations!

@Lash-L Could you better explain how to get the calibration points so users can do it in the mean time? I just moved from HACS integration to Core integration, and I can't find any documentation or tutorial about getting the calibration points from Core integration.

[Lash-L]

@Lash-L I think service call should be ok, but I also thought about implementing a dedicated WS API method. The downside of this approach is that it probably won't be possible for users to use it manually.

It would also be nice to make it possible for the card to be notified that something has changed in the calibration (I think this happens quite often during map building). Can it be solved by generating an event when it happens?

I think conceptually that's okay - i don't know if i really have time for it right now, whereas a service might be easier.

I could also cache the latest mapdata and the service could get the latest mapdata if you think that would be better?

@Lash-L Could you better explain how to get the calibration points so users can do it in the mean time? I just moved from HACS integration to Core integration, and I can't find any documentation or tutorial about getting the calibration points from Core integration.

@carlos-48 You can't. I modified things inside the actual code base in my development environment

[PiotrMachowski]

i don't know if i really have time for it right now, whereas a service might be easier.

Don't worry about it, at this moment I'm rewriting Map Extractor, then I'll have to adjust the card, so you have plenty of time.

I think service call should be enough for my purposes