PipeRift / SaveExtension

Provides UE4 with a save-game system with support for savegame tags, level streaming and more
Apache License 2.0
162 stars 59 forks source link

Build on mac catalina failing #68

Open JWambaugh opened 3 years ago

JWambaugh commented 3 years ago

Describe the bug The latest code from master branch is not compiling on mac for unreal 4.26.1.

This is because of an error in the Test module.

Removing the Test module from the plugin's .uproject file allows the plugin to compile successfully.

To Reproduce

  1. Download latest code and put in a project's plugins directory
  2. regenerate xcode project
  3. Build product

Expected: build projectand plugin c++ Actual result: comilation fails with error

Logs The error message is:

2/4] Compile Module.SaveExtensionTest.gen.cpp
[1/4] Compile Module.SaveExtensionTest.cpp
In file included from /Users/jordan/source/pillager/Plugins/SaveExtension/Intermediate/Build/Mac/x86_64/UE4Editor/Development/SaveExtensionTest/Module.SaveExtensionTest.cpp:2:
In file included from /Users/jordan/source/pillager/Plugins/SaveExtension/Source/Test/Private/Files.spec.cpp:3:
/Users/jordan/source/pillager/Plugins/SaveExtension/Source/Test/Private/Automatron.h:1223:26: error: variable 'PIEStartedHandle' is uninitialized when used within its own initialization [-Werror,-Wuninitialized]
                                [this, OnWorldReady, PIEStartedHandle](const bool bIsSimulating) {
                                                     ^~~~~~~~~~~~~~~~
1 error generated.

Environment (please complete the following information):

xiejiangzhi commented 3 years ago

I made a simple fix for this: maybe you can try it.

https://github.com/PipeRift/SaveExtension/compare/main...xiejiangzhi:osx_fix

xiejiangzhi commented 3 years ago

But I stiil got a codesign error in xcode. image

I don’t know why, but after the compilation is passed(without codesign), the UE4 editor can run the plugin normally.