PipedreamHQ / pipedream

Connect APIs, remarkably fast. Free for developers.
https://pipedream.com
Other
8.29k stars 5.26k forks source link

[Components] acuity-scheduling #11390

Closed pipedream-component-development closed 1 week ago

pipedream-component-development commented 3 weeks ago

acuity_scheduling

URLs

vunguyenhung commented 2 weeks ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-acuity-scheduling-7598caf49a2e40628a517420ee1d3ec6

luancazarine commented 2 weeks ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-acuity-scheduling-7598caf49a2e40628a517420ee1d3ec6

FYI I removed the New Product Order Instant source because the API isn't triggering the event

vunguyenhung commented 2 weeks ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-acuity-scheduling-7598caf49a2e40628a517420ee1d3ec6

vunguyenhung commented 2 weeks ago

Hey @luancazarine, the 2 other remaining sources still does not emit event. Could you check again?

luancazarine commented 2 weeks ago

Hey @luancazarine, the 2 other remaining sources still does not emit event. Could you check again?

Hi @vunguyenhung, I created 2 new appointments image And the events are there image After I canceled these appointments image and the events are there image

vunguyenhung commented 2 weeks ago

Hey @luancazarine, I faced the same issue that event is not emitted. I look into the code and see that there's an issue on base.mjs file, line 28, the getFn() function.

Specifically, it return the function this.acuityScheduling.getAppointment instead of execute that function. I've updated the code as below

image

Then it works image

Could you check again on your side if you have pushed all the changes to the PR?

vunguyenhung commented 2 weeks ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-acuity-scheduling-7598caf49a2e40628a517420ee1d3ec6

luancazarine commented 2 weeks ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-acuity-scheduling-7598caf49a2e40628a517420ee1d3ec6

After I removed the New Order Source, this function is no longer necessary, so I deleted it and called the method directly. Sorry for this mess.

vunguyenhung commented 1 week ago

Hi everyone, all test cases are passed! Ready for release!

Test report https://vunguyenhung.notion.site/Components-acuity-scheduling-7598caf49a2e40628a517420ee1d3ec6