PipedreamHQ / pipedream

Connect APIs, remarkably fast. Free for developers.
https://pipedream.com
Other
8.79k stars 5.26k forks source link

[Components] nioleads #13894

Open pipedream-component-development opened 1 week ago

pipedream-component-development commented 1 week ago

nioleads

URLs

vunguyenhung commented 3 days ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-nioleads-103bf548bb5e8144ac8fcb78ba7e019a

michelle0927 commented 2 days ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-nioleads-103bf548bb5e8144ac8fcb78ba7e019a

@vunguyenhung I think the issue with the source, "New Contact Added", is that the endpoint /new_contacts doesn't actually retrieve all contacts, but only the contacts added since the endpoint was last polled. So, if you retrieve new contacts in an action step, those contacts will then be skipped the next time the source is run. Unfortunately, that's the only endpoint Nioleads provides for retrieving contacts.

vunguyenhung commented 2 days ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-nioleads-103bf548bb5e8144ac8fcb78ba7e019a

michelle0927 commented 17 hours ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-nioleads-103bf548bb5e8144ac8fcb78ba7e019a

@vunguyenhung I've observed that the source in your Pipedream account isn't receiving new contacts. I haven't been able to reproduce the issue in my own account, and I've tried using the same Nioleads account and API key that you had tested with. Could you try testing again, starting with creating a new API key and reconnecting your account? I'm unsure if that will help, but maybe it will provide some new information.

vunguyenhung commented 4 hours ago

Hi @michelle0927, new API Key worked, I'm not sure why though. Maybe an issue on Nioleads side

vunguyenhung commented 4 hours ago

Hi everyone, all test cases are passed! Ready for release!

Test report https://vunguyenhung.notion.site/Components-nioleads-103bf548bb5e8144ac8fcb78ba7e019a