PipedreamHQ / pipedream

Connect APIs, remarkably fast. Free for developers.
https://pipedream.com
Other
8.32k stars 5.27k forks source link

[ACTIONS & SOURCES] Spotify new actions #1762

Closed vellames closed 2 years ago

vellames commented 2 years ago

Is there a specific app this action is for? Spotify

Please provide a link to the relevant API docs for the specific service / operation. https://developer.spotify.com/documentation/web-api/reference/

Actions

Addictional Improvements

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

pipedream-docs-redirect-do-not-edit – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs-redirect-do-not-edit/8hvWdZmxzAfpbD5LUj5a1BWuwTWz
✅ Preview: https://pipedream-docs-redirect-do-not-edit-git-spo-f5404e-pipedreamers.vercel.app

pipedream-docs – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs/7sn5U6evmVkBZsdyoYGNS8U523Wi
✅ Preview: https://pipedream-docs-git-spotify-new-actions-pipedreamers.vercel.app

dylburger commented 2 years ago
vercel[bot] commented 2 years ago

Deployment failed with the following error:

Creating the Deployment Timed Out.
vellames commented 2 years ago

@js07 Should I ping someone to merge this PR?

dannyroosevelt commented 2 years ago

@vellames-turing I can’t set the playlist_id for the “add_items_to_playlist” action. I think it’s trying to list IDs via async options, but I think it should just be a string, right?

Update: I think this is actually a bug within Pipedream! No action required right now, I'll update as soon as I know more.

vellames commented 2 years ago

@dannyroosevelt Yeah. Looks like a bug. I mentioned this before on Slack. If you click on save or deploy the changes are commited. This happens only if useQuery is true. Do you want me to open a new issue?

dannyroosevelt commented 2 years ago

@dannyroosevelt Yeah. Looks like a bug. I mentioned this before on Slack. If you click on save or deploy the changes are commited. This happens only if useQuery is true. Do you want me to open a new issue?

Actually I ran into an entirely separate bug that has since been fixed. I see the one you're referencing though, and Dylan has it on his radar.

dannyroosevelt commented 2 years ago

I can't get save-track to work. Either I get

{
  "error": {
    "status": 400,
    "message": "Malformed json payload"
  }
}

or no response returned (I believe I'm expecting a "Track saved" response).

@vellames-turing are you able to successfully save a track w/ this action?

vellames commented 2 years ago

Weird, is working properly for me. Can you send me your payload?

dannyroosevelt commented 2 years ago

@vellames-turing everything is working for me -- nice job! I just pushed a commit with a bunch of 1-line tweaks to most of the components for a new $export we're adding to the component API (not yet documented...I'm working on that).

$summary will be used to display a human readable success message in the soon-to-be-released new version of our workflow builder. Can you please review my changes and let me know if you have comments / edits, etc?

vellames commented 2 years ago

@vellames-turing everything is working for me -- nice job! I just pushed a commit with a bunch of 1-line tweaks to most of the components for a new $export we're adding to the component API (not yet documented...I'm working on that).

$summary will be used to display a human readable success message in the soon-to-be-released new version of our workflow builder. Can you please review my changes and let me know if you have comments / edits, etc?

The changes look good to me, there are some lint problems. I will fix, reset the version and check if I can improve the summary with the information that you have asked

vellames commented 2 years ago

@dannyroosevelt About the remove-items-from-playlist comment.

// we still show this even if no items were removed, since the API returns success and a "snapshot ID" -- is that weird?

We don't know if the music was removed using the return of this method. In my view, the message it's okay because even if there is nothing to be removed, the command was executed with success.

The snapshot looks okay for me. Its a Spotify control

vellames commented 2 years ago

@js07 @dannyroosevelt I implemented some changes. I tested all actions again. Looks like is everything working. Can you guys double-check it, please?

vellames commented 2 years ago

Hey @dannyroosevelt. I fixed the label/value problem in my last commit

dannyroosevelt commented 2 years ago

@vellames-turing FYI I made 2 of the tweaks Jacob recommended, I'll leave the rest to you

vellames commented 2 years ago

@js07 Requests applied

vellames commented 2 years ago

@dannyroosevelt I will take a look on it ASAP

dannyroosevelt commented 2 years ago

@vellames-turing it all looks good to me! merge away 😄