Create Nordigen Source - New transaction

LucBerge commented 2 years ago

Contribution to #1915 source

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

pipedream-docs-redirect-do-not-edit – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs-redirect-do-not-edit/H68Qn9uvvQu3dyGPzb6oQdVdmwSa
✅ Preview: https://pipedream-docs-redirect-do-not-edit-git-for-62c3e6-pipedreamers.vercel.app

pipedream-docs – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs/5jrzWCTfusjbmG585ekYwoi2cNit
✅ Preview: https://pipedream-docs-git-fork-lucberge-master-pipedreamers.vercel.app

dylburger commented 2 years ago

[ ] Create components to address specific use cases whenever possible
[ ] Component keys should follow the format app_name_slug-slugified-component-name
[ ] Components should follow the standard directory structure
[ ] Prefer Node.js client libraries to REST APIs
[ ] When making API requests, handle pagination to ensure all data / events are processed
[ ] Use secret props to capture sensitive data
[ ] Props and methods should be defined in app files whenever possible
[ ] Document methods with JS Docs
[ ] Use optional props whenever possible, and set a default value where you can
[ ] Use async options to accept user input wherever possible
[ ] Create subscription webhooks sources (vs polling sources) whenever possible
[ ] Always emit a summary with events
[ ] Use a built-in deduping strategy wherever possible
[ ] When building webhook sources, follow these best practices
[ ] When building polling soures, follow these best practices

LucBerge commented 2 years ago

@dylburger It needs some fix in order to match the requirements. I'll do it

dannyroosevelt commented 2 years ago

Thanks for submitting, @LucBerge! Someone from the team will take a look at this and provide feedback asap.

LucBerge commented 2 years ago

@vellames-turing I don't understand why the code linter says:

Error: 135:9 error 'create_requisition_link' is not defined no-undef
Error: 140:7 error 'create_requisition_link' is not defined no-undef

It's working like it on my pipedream account eventhough the deployment fails with pd dev new-transaction.js. I'll turn it to a.mjs file.

vellames commented 2 years ago

Looks like you are using it before defining, eslint does not like this kind of thing. But in this case, the better approach would be to move the code to a method. I will send some suggestions soon :)

vellames commented 2 years ago

Hey @LucBerge, are you able to connect your account? I have tried different browsers and I am not able to connect

dannyroosevelt commented 2 years ago

Hey @LucBerge, are you able to connect your account? I have tried different browsers and I am not able to connect

@vellames-turing I'm able to connect when I pass DE or GB as the country code.

vellames commented 2 years ago

Humm, I am still not able to connect, maybe there is some IP block? @LucBerge are you from some EU country?

LucBerge commented 2 years ago

Thanks, I'll try it.

Humm, I am still not able to connect, maybe there is some IP block? @LucBerge are you from some EU country?

Yes France.

vellames commented 2 years ago

Thanks, I'll try it.

Humm, I am still not able to connect, maybe there is some IP block? @LucBerge are you from some EU country?

Yes France.

Oh, ok, got it. I was able to connect. But I will not be able to test since I do not have a bank account on EU. @dannyroosevelt How should we proceed?

dannyroosevelt commented 2 years ago

Thanks, I'll try it.

Humm, I am still not able to connect, maybe there is some IP block? @LucBerge are you from some EU country?

Yes France.

Oh, ok, got it. I was able to connect. But I will not be able to test since I do not have a bank account on EU. @dannyroosevelt How should we proceed?

That's fine. Try to review as much of the code as possible, and @LucBerge can verify functionality.

LucBerge commented 2 years ago

That's fine. Try to review as much of the code as possible, and @LucBerge can verify functionality.

@vellames-turing Nordigen is read-only. I can grant you access to my bank account transactions for 10 days to try it. You'll just have to send me the requisition link and I'll authorize it.

vellames commented 2 years ago

That's fine. Try to review as much of the code as possible, and @LucBerge can verify functionality.

@vellames-turing Nordigen is read-only. I can grant you access to my bank account transactions for 10 days to try it. You'll just have to send me the requisition link and I'll authorize it.

If you are fine with it, no problem. My email is cassiano.v@turing.com

LucBerge commented 2 years ago

When I create a workflow, with a RSS source, I'm able to see the previous events. But not with my source. Do you know why ?

vellames commented 2 years ago

Question: When I create a workflow, with a RSS source, I'm able to see the previous events but not with my source. Why ?

Could you please share your workflow with me? There is a button share on the top right of your workflow, please share with cassiano.v@turing.com

LucBerge commented 2 years ago

cassiano.v@turing.com

Done. One event should normaly be visible : The requisition link event.

vellames commented 2 years ago

cassiano.v@turing.com

Done. One event should normaly be visible : The requisition link event.

Humm, looks empty for me, do you have access to our slack? We can talk there. Could you please post this same question on #help channel? So me and other developers can help you :)

LucBerge commented 2 years ago

Hey @LucBerge. Great job! It's approved. I was not able to test it because even with your key, I am not able to complete the agreement part. Looks like it needs some personal information. But no need to share with me. Is it working as you expect right now?

Hey, great ! But I would like to try it in real condition first. Let's say 2 weeks to make sure an event is triggered for each transaction. I'll keep you in touch on this pull request.

vellames commented 2 years ago

Hey @LucBerge. Great job! It's approved. I was not able to test it because even with your key, I am not able to complete the agreement part. Looks like it needs some personal information. But no need to share with me. Is it working as you expect right now?

Hey, great ! But I would like to try it in real condition first. Let's say 2 weeks to make sure an event is triggered for each transaction. I'll keep you in touch on this pull request.

I don't think you really need to wait for this. If your concern is only about the automatic trigger, it will work :)

dannyroosevelt commented 2 years ago

@LucBerge if everything is working for you, then @vellames-turing feel free to merge when you're ready!

LucBerge commented 2 years ago

@vellames-turing First events triggered today. Working fine ! You can merge. When will it be deployed on pipedream.com ?

dannyroosevelt commented 2 years ago

Thanks for merging, @vellames-turing!

@LucBerge it's live now 😄 https://pipedream.com/apps/nordigen#popular-nordigen-triggers

PipedreamHQ / pipedream

Create Nordigen Source - New transaction #2011

pipedream-docs-redirect-do-not-edit – ./docs

pipedream-docs – ./docs