1537 action xero accounting new actions

bush4u commented 2 years ago

Danny confirmed it is okay to skip New or updated subscription trigger

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
pipedream-docs	✅ Ready (Inspect)	Visit Preview	May 13, 2022 at 3:18PM (UTC)
pipedream-docs-redirect-do-not-edit	✅ Ready (Inspect)	Visit Preview	May 13, 2022 at 3:18PM (UTC)

dylburger commented 2 years ago

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

[ ] Create components to address specific use cases whenever possible
[ ] Component keys should follow the format app_name_slug-slugified-component-name
[ ] Components should follow the standard directory structure
[ ] Prefer Node.js client libraries to REST APIs
[ ] When making API requests, handle pagination to ensure all data / events are processed
[ ] Use secret props to capture sensitive data
[ ] Props and methods should be defined in app files whenever possible
[ ] Document methods with JS Docs
[ ] Use optional props whenever possible, and set a default value where you can
[ ] Use async options to accept user input wherever possible
[ ] Create subscription webhooks sources (vs polling sources) whenever possible
[ ] Always emit a summary with events
[ ] Use a built-in deduping strategy wherever possible
[ ] When building webhook sources, follow these best practices
[ ] When building polling sources, follow these best practices

DilanAthukorala commented 2 years ago

Hi @bush4u Unable deploy add-line-item-to-invoice action, getting following error

bush4u commented 2 years ago

Hi @bush4u Unable deploy add-line-item-to-invoice action, getting following error

This is done

DilanAthukorala commented 2 years ago

@bush4u please check the following issues;

create_bill action - DueDate is not passing to the xero accounting site.

find_invoice action - following error observed for tenant id

new-updated-contacts / new-updated-invoice sources - observing following error when deploying

bush4u commented 2 years ago

@bush4u please check the following issues;

create_bill action - DueDate is not passing to the xero accounting site.

find_invoice action - following error observed for tenant id

new-updated-contacts / new-updated-invoice sources - observing following error when deploying

I am reproducing the error

bush4u commented 2 years ago

I think that error came up because the DueDate format does not follow YYYY-MM-DD format

bush4u commented 2 years ago

@bush4u please check the following issues; create_bill action - DueDate is not passing to the xero accounting site. find_invoice action - following error observed for tenant id new-updated-contacts / new-updated-invoice sources - observing following error when deploying

I am reproducing the error

I was able to trap this particular error and it is fixed

DilanAthukorala commented 2 years ago

@bush4u Thanks the find_invoice bug is fixed. Please update me once the other issues are fixed.

https://github.com/PipedreamHQ/pipedream/pull/2744#issuecomment-1124247412

bush4u commented 2 years ago

Thanks @DilanAthukorala , The bug has been fixed. Thanks

DilanAthukorala commented 2 years ago

Thanks @DilanAthukorala , The bug has been fixed. Thanks

@bush4u

Observing following issue for the two sources - New or updated contact and New or updated invoice

bush4u commented 2 years ago

Please give me a little while. Not sure why my task is breaking at this time. I will test the sources again end to end

bush4u commented 2 years ago

Thanks for your patience. Most of the bugs were due to previous change requested. I have tested the sources again and they should be fine now. @DilanAthukorala

bush4u commented 2 years ago

Hi @DilanAthukorala , Kindly let mw know if I have any more clarification is required

DilanAthukorala commented 2 years ago

@bush4u I am still seeing the issue for create_bill action where duedate is not updating in the xero accounting side.

DilanAthukorala commented 2 years ago

@bush4u It's better if we can some data to the events in 'New or updated invoice' source.

bush4u commented 2 years ago

@bush4u I am still seeing the issue for create_bill action where duedate is not updating in the xero accounting side.

@DilanAthukorala Hi. I have discovered and fixed the bug

bush4u commented 2 years ago

@bush4u It's better if we can some data to the events in 'New or updated invoice' source.

Done!

DilanAthukorala commented 2 years ago

Verification completed successfully.

bush4u commented 2 years ago

Hi @michelle0927,

Kindly help review for approval. Ticket already passed QA, and it is ready for release

PipedreamHQ / pipedream

1537 action xero accounting new actions #2744